Skip to content

ci(lint): Fix clang_tidy linter check#60

Open
m-olko wants to merge 20 commits intomainfrom
clang_tidy_fix
Open

ci(lint): Fix clang_tidy linter check#60
m-olko wants to merge 20 commits intomainfrom
clang_tidy_fix

Conversation

@m-olko
Copy link
Contributor

@m-olko m-olko commented Feb 2, 2026 •
edited
Loading

This PR

Fixes github workflow definition to actually run against header files. Earlier due to some bugs, the clang_tidy errors were not run or dismissed.

Fixes #62

Notes

In Checks tab, you can see earlier failures due to purposely introduced linter errors earlier in this PR.

@m-olko
Testing clang_tidy error style check
82cbd1b 
Signed-off-by: Marcin Olko <molko@google.com>
@gemini-code-assist
Copy link

gemini-code-assist bot commented Feb 2, 2026

Summary of Changes

Hello @m-olko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing code quality enforcement by configuring clang-tidy to treat all warnings as errors, which will lead to stricter checks in the CI/CD pipeline. Additionally, it includes a minor cleanup in the Bazel build configuration by removing an obsolete flag and a small code formatting fix to ensure proper file termination.

Highlights

  • Clang-Tidy Configuration: Configured clang-tidy to treat all warnings as errors, enforcing stricter code quality checks and preventing builds with warnings.
  • Build Configuration Cleanup: Removed an outdated or unnecessary build --features=-parse_headers flag and its associated comments from the .bazelrc file, streamlining the build configuration.
  • Code Formatting: Addressed a missing newline at the end of the openfeature/evaluation_context.h file, ensuring consistent file formatting.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 2, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables treating clang-tidy warnings as errors, which is a positive change for code quality. I've identified one change that will likely cause a build failure under these new stricter settings—the removal of a newline at the end of a header file. A specific comment with a fix has been provided.

m-olko added 12 commits February 2, 2026 15:56
@m-olko
Add building targets
7c41dfb 
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko
Adding debug check
9d8fef6 
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko
Adding more debug checks
807dda1 
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko
Updating clang-tidy version
5beab78 
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko
More debugging
131eec9 
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko
Removed systemheaders field
fd7721a 
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko
More tests
cb45ddb 
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko
More tests
e0f155f 
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko
Checking if lines matter
d87c477 
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko
Adding system Headers to check
8606215 
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko
Added non header file
ed0ed96 
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko
Trying to resolve symlinks
bc7e9cb 
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko m-olko mentioned this pull request Feb 3, 2026
Open
@m-olko
Trying to enable System headers checks
ee70824 
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko
Merge branch 'main' into clang_tidy_fix
08031e0 
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko
Bumped clang-tidy version
20ebc74 
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko m-olko changed the title Testing clang_tidy error style check ci(lint): Testing clang_tidy error style check Mar 2, 2026
m-olko added 2 commits March 3, 2026 12:37
@m-olko
Remove unused check steps
7fb0610 
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko
Reverted snippets for linter error
1c5683f 
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko m-olko changed the title ci(lint): Testing clang_tidy error style check ci(lint): Fix clang_tidy linter check Mar 3, 2026
@m-olko m-olko marked this pull request as ready for review March 3, 2026 13:39
@m-olko m-olko requested review from a team as code owners March 3, 2026 13:39
@m-olko m-olko requested review from NeaguGeorgiana23 and oxddr March 3, 2026 13:39
@m-olko
Removed incorrect flag
8e91b19 
Signed-off-by: Marcin Olko <molko@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NeaguGeorgiana23 NeaguGeorgiana23 NeaguGeorgiana23 approved these changes

@oxddr oxddr Awaiting requested review from oxddr

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix clang-tidy checks

2 participants

@m-olko @NeaguGeorgiana23